[Scons-dev] PR 3155

[Jason Kenny]

Thanks Bill,
I added the template back. I will update the PR with information about the tests that are fixed with the changed I provided. I did see you wanted a test for the executor change. I provided that information with an existing test that no passes. I will clarify with the next update to the PR comments. I will tag you so it should notify you.
Jason
________________________________
From: Scons-dev <scons-dev-bounces at scons.org> on behalf of Bill Deegan via Scons-dev <scons-dev at scons.org>
Sent: Tuesday, July 24, 2018 10:21 AM
To: SCons developer list
Cc: Bill Deegan
Subject: Re: [Scons-dev] PR 3155

Also you deleted the checklist in the pull request template.
Please add a blurb to src/changes.txt

This is all the normal stuff we ask for all pull requests. That's why it's in the template so hopefully I can avoid asking each and every contributor to do the same thing..

On Tue, Jul 24, 2018 at 8:19 AM, Bill Deegan <bill at baddogconsulting.com<mailto:bill at baddogconsulting.com>> wrote:
I put some feedback on the PR almost as soon as you submitted it that you have yet to respond to.

We need a test which fails under normal scons before your changes and passes after, as we do with pretty much any and all pull requests.

-Bill

On Mon, Jul 23, 2018 at 5:42 PM, Jason Kenny <dragon512 at live.com<mailto:dragon512 at live.com>> wrote:

Hi Bill,



Wanted to know what are your concerns about PR 3155. It current addresses and fixes a number of small issues ( mostly on windows) the pass rate is better.



Any reason for not merging this?



Jason

_______________________________________________
Scons-dev mailing list
Scons-dev at scons.org<mailto:Scons-dev at scons.org>
https://pairlist2.pair.net/mailman/listinfo/scons-dev<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpairlist2.pair.net%2Fmailman%2Flistinfo%2Fscons-dev&data=02%7C01%7C%7C938f16dd07034782dcd408d5f1793040%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636680425151293739&sdata=Xj70bXLfWBIiw2%2BbpkVvPmc5%2FLxKEz%2BrEGIId0mlPW8%3D&reserved=0>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist2.pair.net/pipermail/scons-dev/attachments/20180724/1442124f/attachment-0001.html>