[Scons-dev] PR 3155

[Bill Deegan]

Also you deleted the checklist in the pull request template.
Please add a blurb to src/changes.txt

This is all the normal stuff we ask for all pull requests. That's why it's
in the template so hopefully I can avoid asking each and every contributor
to do the same thing..

On Tue, Jul 24, 2018 at 8:19 AM, Bill Deegan <bill at baddogconsulting.com>
wrote:

> I put some feedback on the PR almost as soon as you submitted it that you
> have yet to respond to.
>
> We need a test which fails under normal scons before your changes and
> passes after, as we do with pretty much any and all pull requests.
>
> -Bill
>
> On Mon, Jul 23, 2018 at 5:42 PM, Jason Kenny <dragon512 at live.com> wrote:
>
>> Hi Bill,
>>
>>
>>
>> Wanted to know what are your concerns about PR 3155. It current addresses
>> and fixes a number of small issues ( mostly on windows) the pass rate is
>> better.
>>
>>
>>
>> Any reason for not merging this?
>>
>>
>>
>> Jason
>>
>> _______________________________________________
>> Scons-dev mailing list
>> Scons-dev at scons.org
>> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist2.pair.net/pipermail/scons-dev/attachments/20180724/9c611686/attachment.html>