[Scons-dev] Question...(not flamebait)

[Bill Deegan]

Anatoly,

This is a bikeshed'ing type discussion.
So we'll never agree on this.

The project has long had the emacs/vim info in each source file, so there's
no reason to change.
That said, some automated checking in buildbot might not be a bad idea.

Though I'd put money that SCons source code (haveing long preceded PEP8
rules) won't conform (at present) to PEP 8.

It might be worthwhile to get there though as such automated checking would
get easier.

Other opinions on PEP-8 formatting compliance?
-Bill


On Mon, Mar 3, 2014 at 11:08 AM, anatoly techtonik <techtonik at gmail.com>wrote:


> Isn't pull request reviews are here to make new people aware of coding

> standards?

> It is better to setup one's editor right for the whole project than to

> save editor

> settings in each file.

>

> If an editor doesn't follow PEP-8 rules for .py files by default, it

> is not Python (and

> SCons) compatible. =)

>

> On Mon, Mar 3, 2014 at 9:41 PM, Bill Deegan <bill at baddogconsulting.com>

> wrote:

> >

> > Have to disagree 100% on this.

> > That's why there's a proliferation of tools to ensure styles are

> followed.

> >

> > -Bill

> >

> >

> > On Mon, Mar 3, 2014 at 6:37 AM, anatoly techtonik <techtonik at gmail.com>

> > wrote:

> >>

> >> On Sun, Mar 2, 2014 at 9:07 PM, Russel Winder <russel at winder.org.uk>

> >> wrote:

> >> > The SCons source files all seem to have Emacs and Vi/Vim data at the

> >> > bottom, but the data seems to just replicate the defaults. I just copy

> >> > and paste for any new files, but is the the right thing to be doing?

> >>

> >> I think this source pollution can be safely abandoned. Humans are able

> to

> >> detect

> >> project rules to be consistent and Vim and Emacs should be able to do so

> >> in

> >> 2014.

> >>

> >> --

> >> anatoly t.

> >> _______________________________________________

> >> Scons-dev mailing list

> >> Scons-dev at scons.org

> >> http://two.pairlist.net/mailman/listinfo/scons-dev

> >

> >

> >

> > _______________________________________________

> > Scons-dev mailing list

> > Scons-dev at scons.org

> > http://two.pairlist.net/mailman/listinfo/scons-dev

> >

>

>

>

> --

> anatoly t.

> _______________________________________________

> Scons-dev mailing list

> Scons-dev at scons.org

> http://two.pairlist.net/mailman/listinfo/scons-dev

>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://two.pairlist.net/pipermail/scons-dev/attachments/20140303/93a5181f/attachment-0001.html>