[reportlab-users] Possible glitch in recently added test

Robin Becker robin at reportlab.com
Wed Apr 14 08:58:31 EDT 2021


Duh, <brain mode="homer-simpson"> was obviously on; seems to work without so thanks eagle eyed person :)

On 14/04/2021 13:26, Lele Gaifax wrote:
> Hi,
> 
> browsing latest changes, I see the following
> 
> diff --git a/tests/test_pdfgen_general.py b/tests/test_pdfgen_general.py
> index 3db17503..5b76521f 100644
> --- a/tests/test_pdfgen_general.py
> +++ b/tests/test_pdfgen_general.py
> @@ -1247,6 +1247,30 @@ def testOSFile(self):
>           c.showPage()
>           c.save()
>   
> +    def testSpooledTemporarySaves(self):
> +        return
> +        from tempfile import SpooledTemporaryFile
> +        with SpooledTemporaryFile() as f:
> +            c = canvas.Canvas(f)
> +            c.drawString(100, 700, 'Hello World I write to %s' % repr(f))
> +            c.showPage()
> +            c.save()
> 
> That early "return" seems a leftover, isn't it?
> 
> ciao, lele.
> 


-- 
Robin Becker


More information about the reportlab-users mailing list