[Scons-dev] Pull request for a small python-2.X related fix

[Thomas Berg]

Hi,

First of all, very happy to see the 3.0.0 release with python 3 support and
move to git and github!

When testing it at my dayjob, I found one minor compatibility issue that I
think has been brought up on the list before: the SConstruct is executed in
a scope where 'from __future__ import print_function' has been used. So
even when running with python 2.7, existing builds that work fine with
scons-2.5.1 and have valid python-2.7 code may get a syntax error in their
SConstruct if they have python 2-style print statements (but not in any
other code this SConscript may import and call). Other than fixing two
print statements, our 20 000 file C++ product built fine with python-2.7,
and I will try python-3 next.

Of course it's easy to fix our print statements, but for us it's also very
convenient to be able to build older versions of our code without having to
have multiple scons versions installed. So I would like to propose this
minor fix to the code which allows us to build everything with scons-3.0:
https://github.com/SConsProject/scons/pull/1

Could someone have a look and let me know if this is sensible, and if I
need to do something else to move it forward?

Thanks,
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist2.pair.net/pipermail/scons-dev/attachments/20170921/bf1386d3/attachment.html>