[Scons-dev] Merging PR #344 && #346

William Blevins wblevins001 at gmail.com
Thu Aug 11 07:40:11 EDT 2016


Tom,

Indeed.

I reviewed 344 again before I wasted anyone's time and found things that
needed to be fixed :(

The other is 345 (not 346); not sure how I managed to mess that up.
https://bitbucket.org/scons/scons/pull-requests/345/optimize-implicit-dependency-scan/diff

V/R,
William

On Thu, Aug 11, 2016 at 8:23 AM, Tom Tanner (BLOOMBERG/ LONDON) <
ttanner2 at bloomberg.net> wrote:

> #346 says 'no differences found'.
>
> Also I notice you have outstanding questions on 344
>
> From: scons-dev at scons.org At: 08/10/16 00:08:21
> To: scons-dev at scons.org
> Subject: Re:[Scons-dev] Merging PR #344 && #346
>
> Krew,
>
> Any odds of merging 344 & 346?
>
> https://bitbucket.org/scons/scons/pull-requests/344/use-
> set-where-it-is-applicable/diff
> https://bitbucket.org/scons/scons/pull-requests/346/check-
> if-targets-have-changed-as-well-as/diff
>
> Both seem reasonable and I expect #346 to be high priority in the next
> release.
>
> I realize we are supposed to be Python3-centric, but it would be nice to
> take fixes as they come :)
>
> V/R,
> William
>
> _______________________________________________
> Scons-dev mailing listScons-dev at scons.orghttps://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
>
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist2.pair.net/pipermail/scons-dev/attachments/20160811/ed3b6f41/attachment.html>


More information about the Scons-dev mailing list