[Scons-dev] Adding Visual Studio 2015 Support to SCons
Bill Deegan
bill at baddogconsulting.com
Thu Jul 23 09:12:06 EDT 2015
Rob,
I forced a rebuild.
Let's see what happens.
-Bill
On Wed, Jul 22, 2015 at 2:12 PM, Rob Smith (WINDOWS) <robs at microsoft.com>
wrote:
> I agree that all the necessary changesets were merged with the pull
> request, and if I pull the latest default branch everything is there and
> the test passes as expected. However, if you look at the changes included
> in build 205, it only has 3 of the 5 changes for some reason:
> http://buildbot.scons.org/builders/win7-64-vs20102.7/builds/205/#changes-
>
>
>
> It looks like build 206 included the two final changes and should have
> passing results, but it failed. Can you trigger a new build or restart
> build 206?
> http://buildbot.scons.org/builders/win7-64-vs20102.7/builds/206#changes-
>
>
>
> *From:* Scons-dev [mailto:scons-dev-bounces at scons.org] *On Behalf Of *Bill
> Deegan
> *Sent:* Tuesday, July 21, 2015 7:20 PM
>
> *To:* SCons developer list
> *Subject:* Re: [Scons-dev] Adding Visual Studio 2015 Support to SCons
>
>
>
> Rob,
>
> That changeset was merged with your pull request, so that should be in the
> code which was run on buildbot.
>
> Looking at the two .sln's you sent, it looks like the format of the sln
> file is 12 for both VS2013 and 2015
>
> vs2013:
> Microsoft Visual Studio Solution File, Format Version 12.00
> # Visual Studio 2013
> VisualStudioVersion = 12.0.31101.0
> MinimumVisualStudioVersion = 10.0.40219.1
>
> vs2015:
> Microsoft Visual Studio Solution File, Format Version 12.00
> # Visual Studio 14
> VisualStudioVersion = 14.0.23023.0
> MinimumVisualStudioVersion = 10.0.40219.1
>
> I can't reproduce that failure on a system I have VS 9.0Exp on either.
>
>
>
> -Bill
>
>
>
> On Tue, Jul 21, 2015 at 5:09 PM, Rob Smith (WINDOWS) <robs at microsoft.com>
> wrote:
>
> Sorry, I had missed that section of the build log (just saw the failed
> test list at the bottom). I just looked at the details for the build, and
> those errors were fixed with this changeset, which was part of my pull
> request:
>
>
>
> changeset: 3333:06c428cb103e
>
> user: Rob Smith <robs at microsoft.com>
>
> date: Mon Jul 20 15:12:33 2015 -0700
>
> summary: Add VS14 support to the solution generation code and fix the
> solution version number (12.0)
>
>
>
> If a build is run against the latest code including all of my changes this
> failure should disappear.
>
>
>
> *From:* Scons-dev [mailto:scons-dev-bounces at scons.org] *On Behalf Of *Bill
> Deegan
> *Sent:* Tuesday, July 21, 2015 1:59 PM
>
>
> *To:* SCons developer list <scons-dev at scons.org>
> *Subject:* Re: [Scons-dev] Adding Visual Studio 2015 Support to SCons
>
>
>
> Rob,
>
> Do you need more that what's in the build logs?
>
> 615/1175 (52.34%) c:\\Python27\\python2.7.exe -tt test\MSVS\vs-14.0-files.py
>
> Traceback (most recent call last):
>
> File "test\MSVS\vs-14.0-files.py", line 66, in <module>
>
> assert sln[:len(expect)] == expect, test.diff_substr(expect, sln)
>
> AssertionError: Actual did not match expect at char 55:
>
> Expect: 'le, Format Version 14.00\n# Visual Studio 14\nProject("{8BC9CE'
>
> Actual: 'le, Format Version 12.00\n# Visual Studio 11\nProject("{8BC9CE'
>
>
>
> 616/1175 (52.43%) c:\\Python27\\python2.7.exe -tt test\MSVS\vs-14.0-scc-files.py
>
> Traceback (most recent call last):
>
> File "test\MSVS\vs-14.0-scc-files.py", line 106, in <module>
>
> assert sln[:len(expect)] == expect, test.diff_substr(expect, sln)
>
> AssertionError: Actual did not match expect at char 55:
>
> Expect: 'le, Format Version 14.00\n# Visual Studio 14\nProject("{8BC9CE'
>
> Actual: 'le, Format Version 12.00\n# Visual Studio 11\nProject("{8BC9CE'
>
>
>
> 617/1175 (52.51%) c:\\Python27\\python2.7.exe -tt test\MSVS\vs-14.0-scc-legacy-files.py
>
> Traceback (most recent call last):
>
> File "test\MSVS\vs-14.0-scc-legacy-files.py", line 89, in <module>
>
> assert sln[:len(expect)] == expect, test.diff_substr(expect, sln)
>
> AssertionError: Actual did not match expect at char 55:
>
> Expect: 'le, Format Version 14.00\n# Visual Studio 14\nProject("{8BC9CE'
>
> Actual: 'le, Format Version 12.00\n# Visual Studio 11\nProject("{8BC9CE'
>
>
>
> -Bill
>
>
>
>
>
> On Tue, Jul 21, 2015 at 2:47 PM, Rob Smith (WINDOWS) <robs at microsoft.com>
> wrote:
>
> Is there any way to view the failure details from those test cases? They
> passed when I ran them locally. I was running the tests on a machine with
> VS2015 installed, is that required for the builder?
>
>
>
> I’ve attached a sample solution file for VS2015 and VS2013, those are the
> two latest versions.
>
>
>
> *From:* Scons-dev [mailto:scons-dev-bounces at scons.org] *On Behalf Of *Bill
> Deegan
> *Sent:* Tuesday, July 21, 2015 7:20 AM
> *To:* SCons developer list <scons-dev at scons.org>
>
>
> *Subject:* Re: [Scons-dev] Adding Visual Studio 2015 Support to SCons
>
>
>
> Rob,
>
> Might you have access to several versions of visual studio?
>
> It would be great to get a sample of .sln files for VS 2015, 2014,...
>
> -Bill
>
>
>
> On Mon, Jul 20, 2015 at 10:30 PM, Bill Deegan <bill at baddogconsulting.com>
> wrote:
>
> Rob,
>
> Looks like some new failures, can you take a look?
>
> http://buildbot.scons.org/builders/win7-64-vs20102.7/builds/205/steps/shell/logs/stdio
>
> -Bill
>
>
>
> On Mon, Jul 20, 2015 at 6:13 PM, Rob Smith (WINDOWS) <robs at microsoft.com>
> wrote:
>
> Thanks for the help! I just uploaded a final commit and now the tests
> are all passing:
> https://bitbucket.org/scons/scons/pull-request/241/add-visual-studio-2015-support-to-scons/commits
>
>
>
> *From:* Scons-dev [mailto:scons-dev-bounces at scons.org] *On Behalf Of *Bill
> Deegan
> *Sent:* Friday, July 17, 2015 3:56 PM
>
>
> *To:* SCons developer list
> *Subject:* Re: [Scons-dev] Adding Visual Studio 2015 Support to SCons
>
>
>
> See around line 1535 of src/engine/SCons/Tool/msvs.py
>
>
>
> On Fri, Jul 17, 2015 at 5:50 PM, Rob Smith (WINDOWS) <robs at microsoft.com>
> wrote:
>
> No, my failures were with the changes I uploaded. The expected result of
> the test is correctly pulling version 14 from TestSConsMSVS.py, it is the
> actual that is failing. What scons code is generating the vcxproj file,
> and how do I fix it?
>
>
>
> C:\sd\scons-vs2015>\Python27\python.exe runtest.py test\MSVS\
> vs-14.0-files.py
>
> 1/1 (100.00%) C:\\Python27\\python.exe -tt test\MSVS\vs-14.0-files.py
>
> Traceback (most recent call last):
>
> File "test\MSVS\vs-14.0-files.py", line 66, in <module>
>
> assert sln[:len(expect)] == expect, test.diff_substr(expect, sln)
>
> AssertionError: Actual did not match expect at char 55:
>
> Expect: 'le, Format Version 14.00\n# Visual Studio
> 14\nProject("{8BC9CE'
>
> Actual: 'le, Format Version 12.00\n# Visual Studio
> 11\nProject("{8BC9CE'
>
>
>
> *From:* Scons-dev [mailto:scons-dev-bounces at scons.org] *On Behalf Of *Bill
> Deegan
> *Sent:* Friday, July 17, 2015 2:29 PM
>
>
> *To:* SCons developer list
> *Subject:* Re: [Scons-dev] Adding Visual Studio 2015 Support to SCons
>
>
>
> I guess really most importantly we should check if the format of the .sln
> an other msvs project files has changed any and make sure that what SCons
> generates matches?
>
> (Besides making a test pass)
>
> -Bill
>
>
>
> On Fri, Jul 17, 2015 at 5:28 PM, Bill Deegan <bill at baddogconsulting.com>
> wrote:
>
> Rob,
>
> Did that resolve your failures?
>
> -Bill
>
>
>
> On Fri, Jul 17, 2015 at 5:10 PM, Rob Smith (WINDOWS) <robs at microsoft.com>
> wrote:
>
> I’ve uploaded the latest changes, I switched the values in TestSConsMSVS
> to 14 inside the text. You can see the latest here:
> https://bitbucket.org/robsmsft/scons-vs2015/commits/all
>
>
>
> *From:* Scons-dev [mailto:scons-dev-bounces at scons.org] *On Behalf Of *Bill
> Deegan
> *Sent:* Friday, July 17, 2015 12:02 PM
>
>
> *To:* SCons developer list
> *Subject:* Re: [Scons-dev] Adding Visual Studio 2015 Support to SCons
>
>
>
> Rob,
>
> Looks like you modified QMTest/TestSConsMSVS.py but didn't check it in so
> I can't tell.
>
> But likely you copy/pasted the text from the _11_ to your _14_ and need to
> change to 14?
>
> Or... Do you have several versions of MSVS installed on your test machine?
>
>
>
> -Bill
>
>
>
> TestSConsMSVS.expected_slnfile_14_0
>
>
>
>
>
> On Fri, Jul 17, 2015 at 2:19 PM, Rob Smith (WINDOWS) <robs at microsoft.com>
> wrote:
>
> I created the new tests and vs-14.0-exec.py is passing as expected.
> However, I’m hitting a failure with the other test cases and I don’t have
> enough knowledge of what the test is doing to figure out the issue.
>
>
>
> You can see the error below, I’ve updated the expected results to version
> 14, but it appears the Test.vcxproj generated by the test is still
> returning version 12. Where is this project file being generated, and how
> is it fixed?
>
>
>
> C:\sd\scons-vs2015>\Python27\python.exe runtest.py test\MSVS\
> vs-14.0-files.py
>
> 1/1 (100.00%) C:\\Python27\\python.exe -tt test\MSVS\vs-14.0-files.py
>
> Traceback (most recent call last):
>
> File "test\MSVS\vs-14.0-files.py", line 66, in <module>
>
> assert sln[:len(expect)] == expect, test.diff_substr(expect, sln)
>
> AssertionError: Actual did not match expect at char 55:
>
> Expect: 'le, Format Version 14.00\n# Visual Studio
> 14\nProject("{8BC9CE'
>
> Actual: 'le, Format Version 12.00\n# Visual Studio
> 11\nProject("{8BC9CE'
>
>
>
> *From:* Scons-dev [mailto:scons-dev-bounces at scons.org] *On Behalf Of *Bill
> Deegan
> *Sent:* Wednesday, July 15, 2015 2:52 PM
> *To:* SCons developer list
> *Subject:* Re: [Scons-dev] Adding Visual Studio 2015 Support to SCons
>
>
>
> Rob,
>
> Thanks for the pull request.
>
> I looked at it yesterday.
>
> I was just refreshing my memory what tests we had for supporting each
> version of visual studio.
>
> Looks like we have tests for most versions of visual studio.
>
> Can you replicate what's in tests/MSVS for version 14?
>
> Generally we like to have some tests to cover all code additions/changes.
>
> By chance can Microsoft provide any buildbot slaves with each version of
> visual studio on it?
> http://buildbot.scons.org/waterfall
>
> We're always struggling to have a reasonable number of windows base
> buildbot slaves for platform testing.
>
>
>
> Thanks,
>
> Bill
>
> Co-Manager SCons Project
>
>
>
>
>
> On Wed, Jul 15, 2015 at 5:07 PM, Rob Smith (WINDOWS) <robs at microsoft.com>
> wrote:
>
> I’ve submitted a pull request to add VS2015 support to SCons, what
> additional steps do I need to follow to get the patch submitted? Also, when
> is the next planned SCons release? As VS2015 is already available, we would
> love to have an official SCons release with support in the near future.
>
>
>
>
> https://bitbucket.org/scons/scons/pull-request/241/add-visual-studio-2015-support-to-scons/diff
>
>
>
> Thanks for the help,
>
> Rob
>
>
>
>
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
>
>
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
>
>
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
>
>
>
>
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
>
>
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
>
>
>
>
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
>
>
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
>
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist2.pair.net/pipermail/scons-dev/attachments/20150723/890982c8/attachment-0001.html>
More information about the Scons-dev
mailing list