[Scons-dev] mimetypes: adding mimetype for scons scripts

[Carnë Draug]

On 21 January 2015 at 13:28, Carnë Draug <carandraug+dev at gmail.com> wrote:
> On 21 January 2015 at 13:15, Gary Oberbrunner <garyo at oberbrunner.com> wrote:
>>
>> On Wed, Jan 21, 2015 at 8:05 AM, Carnë Draug <carandraug+dev at gmail.com>
>> wrote:
>>>
>>> ...
>>> >>> scons [1] is a build system and I was thinking of adding it to
>>> >>> shared-mime-info.  Its files are very simple to identify, they are
>>> >>> always named SConstruct or SConscript.  These files are also valid
>>> >>> python scripts.
>>> >>>
>>> >>> Should shared-mime-info identify them (I can submit a git patch, no
>>> >>> problem)
>>
>>
>> This seems like an easy thing to add, with some possible upside and no
>> downside.  So why not, I say. Carnë, I think it would be better for you to
>> add it to shared-mime-info; SCons could do it but (a) it would be more
>> complex, and (b) it wouldn't identify SConstructs when SCons isn't
>> installed.
>>
>
> Yes. shared-mime-info seems to agree with, they only need acceptance from
> scons developers:
>
> On 20 January 2015 at 18:32, Jerome Leclanche <adys.wh at gmail.com> wrote:
>>
>> If a text/x-scons mime type is defined and accepted by the SCons devs,
>> it would then be a sub-type of text/x-python.
>> J. Leclanche
>
> So unless someone opposes I will submit a patch to shared-mime-info.
> Regarding
>
> On 21 January 2015 at 01:28, William Blevins <wblevins001 at gmail.com> wrote:
>> [...]
>> SConstruct is a required name, but SConscript is not even though it may be
>> the standard/convention.  The subscripts can use any name you like
>> technically.  I usually include the "*.py" extension so that language
>> bindings in editors work without setting changes.
>
> what if the magic uses the following globs for filenames "SConstruct",
> "SConscript", and "SConscript.*" ?


I have just added a patch for this to bug #87920 [1].  Could someone
review it please?

I also add 3 new tests based on SCons configuration which I found on the
repositories for MongoDB, Battle for Wesnoth, and SCons itself.

Carnë

[1] https://bugs.freedesktop.org/show_bug.cgi?id=87920