[Scons-dev] Tests for SCons.Debug

[anatoly techtonik]

I see. The problem is that in professional reviews that
I used to, the phrase "Test?" from reviewer without any
other context means that the change needs a test that
is missing.

I also think that the conflict could be resolved earlier if
you let me know that you do not think that this change
should have an obligatory test. That was the point of
conflict.


On Thu, Nov 26, 2015 at 2:02 AM, Bill Deegan <bill at baddogconsulting.com> wrote:
> Anatoly,
>
> If instead of being argumentative when asked some questions about your pull
> request, you'd simply answered the questions, it's likely we'd long have
> merged your pull request.
> But you prefer to argue.
>
> The process for a pull request is pretty simple.
> If the pull request changes something user visible then CHANGES.txt should
> be updated.
> If the pull request has a functional change, then there should be some
> tests.
>
> If I see either missing, I'll ask in the pull request for what's missing.
> If you think this process is unreasonable, then you should bring it to a
> discussion on the dev mailing list, and not argue about it in a pull
> request.
> If you think that testing the change would be overwhelming difficult or
> ineffective, then the pull requester is free to make that argument.
>
> For this pull request, I asked for tests.
> You responded with some posting  "Unit Testing Is Not a Panacea".
>
> If you'd simply answered the questions asked, you wouldn't have wasted
> anyone's times including your own.
> And if you'll simply answer the questions asked now, in the pull request,
> I'm sure we can get it merged.
>
> But if you continue to be argumentative, I'm likely to spend my time on less
> frustrating (and productive) tasks.
>
> -Bill
>
>
> On Wed, Nov 25, 2015 at 12:10 AM, anatoly techtonik <techtonik at gmail.com>
> wrote:
>>
>> Hi.
>>
>> We can't make this merged, and I am wasting my emotions on
>> useless discussion instead of doing something useful for SCons.
>> Please tell me if you find it useful to write the test for the following
>> debug function, because I definitely don't see it as such:
>>
>>
>> https://bitbucket.org/scons/scons/pull-requests/271/document-sconsdebugcaller_trace-behavior/diff
>>
>> --
>> anatoly t.
>> _______________________________________________
>> Scons-dev mailing list
>> Scons-dev at scons.org
>> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
>
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>



-- 
anatoly t.