[Scons-dev] PR #195 : TempFileMunge duplicate output and duplicated temporary file generation fixed.

[Laurent Marchelli]

With test log ...

2014-11-26 17:13 GMT+01:00 Laurent Marchelli <laurent.marchelli at gmail.com>:

> Hello,
>
> Please find attached all information needed to evaluate the PR #195
> <https://bitbucket.org/scons/scons/pull-request/195/tempfilemunge-duplicate-output-and>
> - It is a very simple hack, the fix is less than 10 lines long localized
> in one function.
> - Unary tests provided
> - Complete test log attached.
> - Tested on our build environment to generate our programs.
>
> Failed the following 3 tests:
>         test\Interactive\configure.py
>         test\import.py
>         test\site_scons\override.py
>
> *1. Description :*
> When the command line exceed the limit 'MAXLINELENGTH':
> - SCons displays the command line twice.
> - SCons creates two temporary files.
> - The first temporary file is not removed from the temporary directory.
>
> *2. How to reproduce the bug :*
> SConstruct :
> env = Environment()
> AddOption('--bug', action='store_true', dest='bug', default=False)
> env['CPPPATH'] = "C:\\Program Files (x86)\\GnuWin32\\include;"
> env['LIBPATH'] = "C:\\Program Files (x86)\\GnuWin32\\lib;"
> if GetOption('bug') :
>     env['MAXLINELENGTH'] = len(env['LIBPATH'])-1
> env.Program("scons-test.cpp")
>
> *3. BEFORE FIX : --bug option*
> set MYSCONS=C:\dev\scons\scons-trunk\src
> set SCONS_LIB_DIR=C:\dev\scons\scons-trunk\src\engine
> python C:\dev\scons\scons-trunk\src\script\scons.py --bug
> scons: Reading SConscript files ...
> scons: done reading SConscript files.
> scons: Building targets ...
> Using tempfile c:\users\lmarchel\appdata\local\temp\tmpuwlgfd.lnk for
> command line:
> cl /Foscons-test.obj /c scons-test.cpp /TP /nologo "/IC:\Program Files
> (x86)\GnuWin32\include"
> cl @c:\users\lmarchel\appdata\local\temp\tmpuwlgfd.lnk
> Using tempfile c:\users\lmarchel\appdata\local\temp\tmpgiac3e.lnk for
> command line:
> cl /Foscons-test.obj /c scons-test.cpp /TP /nologo "/IC:\Program Files
> (x86)\GnuWin32\include"
> scons-test.cpp
> Using tempfile c:\users\lmarchel\appdata\local\temp\tmphgszq5.lnk for
> command line:
> link /nologo /OUT:scons-test.exe "/LIBPATH:C:\Program Files
> (x86)\GnuWin32\lib" scons-test.obj
> link @c:\users\lmarchel\appdata\local\temp\tmphgszq5.lnk
> Using tempfile c:\users\lmarchel\appdata\local\temp\tmpk6qdjf.lnk for
> command line:
> link /nologo /OUT:scons-test.exe "/LIBPATH:C:\Program Files
> (x86)\GnuWin32\lib" scons-test.obj
> scons: done building targets.
>
> *4. AFTER FIX : **--bug option :*
> set MYSCONS=C:\dev\scons\scons-lmarchel\src
> set SCONS_LIB_DIR=C:\dev\scons\scons-lmarchel\src\engine
> python C:\dev\scons\scons-lmarchel\src\script\scons.py --bug
> scons: Reading SConscript files ...
> scons: done reading SConscript files.
> scons: Building targets ...
> Using tempfile c:\users\lmarchel\appdata\local\temp\tmpzdysls.lnk for
> command line:
> cl /Foscons-test.obj /c scons-test.cpp /TP /nologo "/IC:\Program Files
> (x86)\GnuWin32\include"
> cl @c:\users\lmarchel\appdata\local\temp\tmpzdysls.lnk
> scons-test.cpp
> Using tempfile c:\users\lmarchel\appdata\local\temp\tmpnr5njk.lnk for
> command line:
> link /nologo /OUT:scons-test.exe "/LIBPATH:C:\Program Files
> (x86)\GnuWin32\lib" scons-test.obj
> link @c:\users\lmarchel\appdata\local\temp\tmpnr5njk.lnk
> scons: done building targets.
>
> Regards,
> Laurent Marchelli
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist2.pair.net/pipermail/scons-dev/attachments/20141126/124d9e80/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scons-lmarchel.log
Type: application/octet-stream
Size: 96774 bytes
Desc: not available
URL: <https://pairlist2.pair.net/pipermail/scons-dev/attachments/20141126/124d9e80/attachment-0001.obj>