[Scons-dev] Scons 2.3.2 regression, D tool...

[Russel Winder]

On Sat, 2014-08-09 at 20:09 +0200, Dirk Bächle wrote:
[…]
> I think it is extremely helpful to create this PR right now. The sooner 
> we can test this in the mainline (and against our Buildbots), and the 
> sooner users can pull a fixed version straight from the repo for 
> testing, the better it is for us.
> We have clearly identified the issue and have a fix for it. Let's not 
> wait...

Duly done, #166.

> > We do need a test for this, but I am not sure what form it should take
> > so all suggestions welcome.
> I don't think we need an extra test. There are lots of D tool tests 
> already, and the existing C/C++ tests actually triggered errors on the 
> Windows buildslave...but nobody had a closer look because the buildbot 
> stuff was in a bad state recently. So the "all red" appeared to be normal.
> 
> This is a fix for a previous commit, so there doesn't have to be a test 
> for it, IMO. The actual testing would be to have one Buildslave under 
> Windows with D tools installed, and another one without.
> So again, feel free to leap ahead and remove the offending line...no 
> tests required from my side.
> And if things go havoc this time, you can put the blame on me afterwards. ;)

Anatoly is right to point out that there are some claimed situations not
supported by tests that should be supported by tests. So there ought to
be more tests.

I am not sure though there is a specific test for this case anyway apart
from the ones there.

-- 
Russel.
=============================================================================
Dr Russel Winder      t: +44 20 7585 2200   voip: sip:russel.winder at ekiga.net
41 Buckmaster Road    m: +44 7770 465 077   xmpp: russel at winder.org.uk
London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <http://two.pairlist.net/pipermail/scons-dev/attachments/20140809/ff8f804d/attachment.pgp>