[Scons-dev] Found and fixed bug regarding variant_dir on cygwin

[Bogdan Tenea]

I have attached a small little test case to be used only on cygwin.

From: scons-dev-bounces at scons.org [mailto:scons-dev-bounces at scons.org] On Behalf Of Bill Deegan
Sent: Sunday, September 29, 2013 8:39 PM
To: SCons developer list
Subject: Re: [Scons-dev] Found and fixed bug regarding variant_dir on cygwin

Do you have a small test case to demonstrate the issue?
-Bill

On Sun, Sep 29, 2013 at 6:34 AM, Bogdan Tenea <btenea at ixiacom.com<mailto:btenea at ixiacom.com>> wrote:
Hello,

At this moment variant_dir option does not work on Cygwin due to the fact that it does not copy headers (I reported this on scons-users a few days ago).
After some digging into the source code I found that for headers it makes the path upper case for source dir listing, but not for the file to be copied that is checked versus the dir listing.
The problem cand be fixed with a simple modification in FS.py on line 1844 (function entry_exists_on_disk) by extending the condition to also include cygwin:

                if sys.platform == 'win32' or sys.platform == 'cygwin':

Hoping this will get included in the next version :)

Regards,

Bogdan Tenea
Senior Software Engineer II
Ixia RO Stack Manager Dev

_______________________________________________
Scons-dev mailing list
Scons-dev at scons.org<mailto:Scons-dev at scons.org>
http://two.pairlist.net/mailman/listinfo/scons-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://two.pairlist.net/pipermail/scons-dev/attachments/20130930/7718cd60/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_variant_dir_cygwin.zip
Type: application/x-zip-compressed
Size: 919 bytes
Desc: test_variant_dir_cygwin.zip
Url : <http://two.pairlist.net/pipermail/scons-dev/attachments/20130930/7718cd60/attachment-0001.bin>