[Scons-dev] [scons-dev] fix for 2903 breaks LIBPATH.py test..

[Gary Oberbrunner]

I just pushed a fix which I think is now correct.  Alexandre's original fix
was the right way to do it, because we do want to depend on all the link
args.  But the varlist code itself was broken, and wasn't ignoring $(...$)
parts of variables, which broke the LINKPATH test.  I fixed the varlist
code to work the same way regular command actions do and now all the tests
pass.  I updated the test as well.


On Sun, Oct 27, 2013 at 4:29 AM, <alexandre.feblot at gmail.com> wrote:


> Yes,

> that was my initial conclusion. This commit changed:

>

> ShLibAction = SCons.Defaults.ShLinkAction(target, source, envlink)

> to:

>

> def VersionedSharedLibrary(target = None, source= None, env=None):

>     ...

>     result = SCons.Defaults.ShLinkAction(target, source, envlink)

>     ...

>     return result

> ShLibAction = SCons.Action.Action(VersionedSharedLibrary, None)

>

> --

> SCons.Defaults.ShLinkAction is a string action, the string being

> SHLINKCOM, and this is why I re-added it with:

> ShLibAction = SCons.Action.Action(VersionedSharedLibrary, None,

> varlist=['SHLINKCOM'])

>

> So, except strange side effects that I could not imagine because I'm a

> real Scons code newbie, I would have thought that the final behavior is the

> same than the one before the versionned libraries addition.

>

> _______________________________________________

> Scons-dev mailing list

> Scons-dev at scons.org

> http://two.pairlist.net/mailman/listinfo/scons-dev

>




-- 
Gary
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://two.pairlist.net/pipermail/scons-dev/attachments/20131027/4a231c90/attachment.html>