[Scons-dev] [scons-dev] fix for 2903 breaks LIBPATH.py test..

[Gary Oberbrunner]

[this was sent to the old obsolete SCons dev list, btw.  Forwarding to the
new one.]



On Thu, Oct 24, 2013 at 11:22 PM, William Deegan
<bill at baddogconsulting.com>wrote:


> Gary,

>

> I see this merge:

>

> https://bitbucket.org/scons/scons/pull-request/86/fix-http-sconstigrisorg-issues/diff

>

> I did a hg bisect on failure of test/Libs/LIBPATH.py and it tracks down to

> that checkin.

>

> The failing test in LIBPATH changes the LIBPATH and expects that no

> rebuild will be caused by it.

> Prior build was same library with same library sources.

> So it shouldn't have been rebuilt.

>

> I think:

> a) no new test was added with the merge.

> b) Likely using SHLINKCOM was too broad to resolve the problem in

> question, and is thus causing this rebuild.

>

> Or am I misunderstanding the issue?

>


No, you're exactly right.  I noticed the same thing you did; SHLINKCOM is
too broad.  I agree that's the commit that causes the test failure. I've
got some code on my machine at home that does better, but it still not
perfect.  (I don't have full access here but I thought I did add a test
after the merge?)

-- 
Gary
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://two.pairlist.net/pipermail/scons-dev/attachments/20131025/a66cacbe/attachment.htm>