[reportlab-users] Patch to support tables with oversize cells

[Lennart Regebro]

OK, that seems to have been the only case of me setting attributes on
T/self.

However, I also added a matrixCopy() function and used it the cases where I
modify _cellvalues and _cellStyles, to make sure the original table doesn't
get modified that way.

On Mon, May 30, 2022 at 3:24 PM Lennart Regebro <lregebro at shoobx.com> wrote:

> On Mon, May 30, 2022 at 3:01 PM Robin Becker <robin at reportlab.com> wrote:
>
>> For whatever reason we have T is self in the non-splitInRow case so we
>> have to be careful about assignments to T.attr in
>> the code executed by that branch.
>>
>
> Ah, yes, of course, the penny dropped now. I forgot about that, and
> probably ended up setting things on T without thinking about it.
>
>
>> I think on the other branch we create a new T, but it's not clear that we
>> are setting stuff back on self unless some
>> mutable is shared and then modified.
>>
>
> I'll make a code review in this with this insight, and come back to you,
> likely with a verion 8.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist2.pair.net/pipermail/reportlab-users/attachments/20220530/268c5af1/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: splitInRow-v8.diff
Type: text/x-patch
Size: 53893 bytes
Desc: not available
URL: <https://pairlist2.pair.net/pipermail/reportlab-users/attachments/20220530/268c5af1/attachment-0001.bin>