[reportlab-users] ReportLab 2.6 Bugs

[Robin Becker]

On 21/12/2012 13:55, Stephan Richter wrote:

>.........

>

> That is correct, but the initialization code is not called. I am surprised

> that your Pie3d tests would pass at all. Basically, my z3c.rml testsuite fails

> for 3D pie charts without that fix.

>

> Note how Pie3d overwrites __init__ without a super call, but Pie.__init__

> clearly sets sideLabels.

>


yes I think you are right, the bug is in the Pie3d code though and shouldn't be 
fixed by patching a reset.


> I also think that there are no tests for Pie3d. Could it be that z3c.rml is

> the most comprehensive testsuite? I need to do a coverage test run to see how

> much code coverage I get in z3c.rml and reportlab. (I should really add

> support/tests for some of the iconic widgets to make it more complete.)

.......


We do have some tests for various Pie3d charts, but those aren't in the main 
tests. Most of those are to do with testing for bitmap images leaking fills at 
small angles etc etc (ie for failures in the bitmap rasterizer). I made the 
obvious change to Pie3d to fix this issue and those are passing still so I will 
commit all of your recommendations today.
-- 
Robin Becker